[tor-bugs] #26366 [Core Tor/Tor]: Possible duplicated logic in connection_edge_finished_connecting() and connection_exit_connect()

[Tor Bug Tracker & Wiki]

#26366: Possible duplicated logic in connection_edge_finished_connecting() and
connection_exit_connect()
------------------------------+------------------------------
     Reporter:  ahf           |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: unspecified
    Component:  Core Tor/Tor  |    Version:  Tor: unspecified
     Severity:  Normal        |   Keywords:  tor-hs
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+------------------------------
 There's some possible duplicated logic in
 `connection_edge_finished_connecting()` and `connection_exit_connect()`:

 When `conn->state = EXIT_CONN_STATE_OPEN` is set we have some duplicated
 code on when to begin writing. There is a comment that might be relevant
 around some Windows logic in the switch/case block around the `result`
 variable in `connection_exit_connect()`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26366>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online