[tor-bugs] #26282 [Core Tor/Tor]: Smartlist index implicitly converted to int

[Tor Bug Tracker & Wiki]

#26282: Smartlist index implicitly converted to int
--------------------------+------------------------------------
 Reporter:  rl1987        |          Owner:  rl1987
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #26196        |         Points:
 Reviewer:  ahf           |        Sponsor:
--------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Patch looks good to me.

 I think it could make sense to switch the `idx` fields to be an unsigned
 type, but I think that would probably generate even more warnings in these
 smartlist debug builds, so I think this patch is good as it is.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26282#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online