[tor-bugs] #26326 [Applications/Tor Browser]: wine error when building Firefox ESR60 Windows x86_64

[Tor Bug Tracker & Wiki]

#26326: wine error when building Firefox ESR60 Windows x86_64
--------------------------------------------+--------------------------
 Reporter:  sukhbir                         |          Owner:  tbb-team
     Type:  defect                          |         Status:  new
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806  |  Actual Points:
Parent ID:  #26203                          |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+--------------------------

Comment (by tom):

 Replying to [comment:12 sukhbir]:
 > Two errors:
 >
 > (1):
 >
 > {{{
 >  4:18.25 /var/tmp/build/firefox-
 dd0fed4bd34c/security/certverifier/Buffer.cpp: In function 'bool
 mozilla::operator==(const Buffer&, const Buffer&)':
 >  4:18.25 /var/tmp/build/firefox-
 dd0fed4bd34c/security/certverifier/Buffer.cpp:15:73: error: 'memcmp' was
 not declared in this scope
 >  4:18.25      (a.length() == b.length() && memcmp(a.begin(), b.begin(),
 a.length()) == 0);
 > }}}
 >
 > Simple fix for this (did anyone else get this? I wonder why not...):
 >
 > {{{
 > diff --git a/security/certverifier/Buffer.cpp
 b/security/certverifier/Buffer.cpp
 > index a36bfeabc13f..407d45a41253 100644
 > --- a/security/certverifier/Buffer.cpp
 > +++ b/security/certverifier/Buffer.cpp
 > @@ -5,6 +5,7 @@
 >   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 >
 >  #include "Buffer.h"
 > +#include <cstring>
 >
 >  namespace mozilla {
 > }}}


 Firefox uses a unified build system that smashes several .cpp files into a
 single one. If you have any local patches that edit any file in the
 directory, it's likely it changed the order of unified builds and thus it
 lost the include that it was getting from another file. We generally don't
 pay much mind to these types of errors but feel free to send a patch
 upstream.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26326#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online