[tor-bugs] #26227 [Core Tor/Stem]: Review existing stem.client code
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jun 11 07:04:27 UTC 2018
#26227: Review existing stem.client code
---------------------------+------------------------------
Reporter: dmr | Owner: dmr
Type: task | Status: needs_review
Priority: Medium | Milestone:
Component: Core Tor/Stem | Version:
Severity: Normal | Resolution:
Keywords: client | Actual Points:
Parent ID: | Points:
Reviewer: atagar | Sponsor:
---------------------------+------------------------------
Changes (by dmr):
* status: assigned => needs_review
* reviewer: => atagar
Comment:
atagar: commits are ready for your review in
[[https://github.com/torproject/stem/pull/1|this pull request on GitHub]].
(Branch head `79396f510ba5713ec5aea78dcaee66d9dd045399`.)
The github master was 1 commit behind the git.tpo master, so I rebased to
the github master in case github would otherwise get confused with the PR.
The commits should be pretty self-explanatory, but feel free to ask any
questions or comment. If you've code code changes you'd suggest/require,
let's try out the GitHub review features!
I've got more comments that didn't make it into changes, and I'll be
adding those within the next day. Sorry for the delay!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26227#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list