[tor-bugs] #24891 [Core Tor/Tor]: build system --disable-unittests has no effect

[Tor Bug Tracker & Wiki]

#24891: build system --disable-unittests has no effect
-------------------------------------------------+-------------------------
 Reporter:  starlight                            |          Owner:  rl1987
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.5.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  034-triage-20180328,                 |  Actual Points:
  034-removed-20180328, 029-backport             |
Parent ID:                                       |         Points:  1
 Reviewer:  isis                                 |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------
Changes (by isis):

 * version:  Tor: 0.3.2.9 => Tor: 0.2.5.1-alpha
 * points:   => 1
 * sponsor:   => Sponsor8-can
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final
 * keywords:  034-triage-20180328, 034-removed-20180328 =>
     034-triage-20180328, 034-removed-20180328, 029-backport
 * reviewer:  mikeperry => isis


Comment:

 LGTM! Thanks rl1987!

 It seems Mike and I both got assigned this ticket for review this week,
 which I'm assuming was a typo on the assignment spreadsheet.  Since I
 already got to it, I'm removing Mike and adding myself, but Mike you
 should feel free to add yourself back in if you want to review as well.

 I'm nominating this for backport to 0.2.9.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24891#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online