[tor-bugs] #26233 [Applications/Tor Browser]: Rebase Tor Browser patches for FF61

Fri Jun 1 22:55:49 UTC 2018

#26233: Rebase Tor Browser patches for FF61
----------------------------------------------+----------------------------
 Reporter:  sysrqb                            |          Owner:  sysrqb
     Type:  enhancement                       |         Status:
                                              |  needs_review
 Priority:  Very High                         |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  TorBrowserTeam201805, tbb-mobile  |  Actual Points:
Parent ID:  #25741                            |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------
Changes (by arthuredelstein):

 * status:  accepted => needs_review

Comment:

 Here's my branch, which I created by rebasing tor/tor-
 browser-60.0.1esr-8.0-1 (30544586f8a98e985e0038b2e905bfddb14e999e) onto a
 recent gecko-dev/beta (c432661a14b1ad331e22e2524ae8d57f9161884f):

 https://github.com/arthuredelstein/tor-browser/commits/26233

 I left out three updater patches that are complex to rebase and I think
 won't be needed for Android in any case (please correct me if I'm wrong!).
 I also squashed the fixup commits.

 Here's what happened to each patch:

 {{{
 C = cherry-picked
 F = fixed up
 U = upstreamed
 ? = left out for now (updater patches)

 C 30544586f8a9 fixup! TB4: Tor Browser's Firefox preference overrides.
 F b135c59f65db Fix MAR generation bashism
 C 1ba7b6b25113 fixup! TB4: Tor Browser's Firefox preference overrides.
 C b589ec74c427 Bug 20283: Tor Browser should run without a `/proc`
 filesystem.
 C 3a6cb718e815 Bug 21537: Tests for secure .onion cookies
 C 58e4a739a6ed Bug 21537: Mark .onion cookies as secure
 U 440d2fe1b6f4 Bug 1441327 - Allow for seccomp filtering of
 socket(AF_INET/AF_INET_6) calls on Linux when using UNIX Domain Sockets
 for SOCKS Proxy. r=bagder
 C ed1a45a69d15 Bug 22548: Firefox downgrades VP9 videos to VP8.
 C 550d0bae6d40 Bug 24398: Plugin-container process exhausts memory
 F 3206814bc291 Bug 23104: Add a default line height compensation
 C 53f7ab7d844a Bug 24052: Handle redirects by blocking them early
 C 5e0170a7ca05 Bug 13398: at startup, browser gleans user FULL NAME (real
 name, given name) from O/S
 C c5544f727e46 Bug 21830: Copying large text from web console leaks to
 /tmp
 C 962babebfc5e Bug 21321: Add test for .onion whitelisting
 F d18befdee332 Bug 21431: Clean-up system extensions shipped in Firefox 52
 C fe68460a72cd Bug 21569: Add first-party domain to Permissions key
 C 2aa950923c66 Bug 16285: Exclude ClearKey system for now
 C 32da0487944c Bug 21907: Fix runtime error on CentOS 6
 C d010f98a92fe Bug 21849: Don't allow SSL key logging
 F d29c1ddb254d Bug #5741: Prevent WebSocket DNS leak.
 F c67a0c07fd5b Bug 14970: Don't block our unsigned extensions
 F 3549c5324dda Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter;
 remove Amazon, eBay, bing
 C e984b8c54c75 Bug 23916: Add new MAR signing key
 ? 70989b5211d8 Bug 16940: After update, load local change notes.
 ? 189164e100db Bug 13379: Sign our MAR files.
 ? 4b4dcd40abae Bug 4234: Use the Firefox Update Process for Tor Browser.
 C 7ca562c26856 Bug 25909: disable updater telemetry
 C 39f10aaa10ef Bug 19121: reinstate the update.xml hash check
 C 9a3bb35800d5 Bug 19121: reinstate the update.xml hash check
 F a4ac08e62457 Bug 13252: Do not store data in the app bundle
 C cab08be85615 Bug 21724: Make Firefox and Tor Browser distinct macOS apps
 C 75d638dddd7d Bug 18912: add automated tests for updater cert pinning
 C b95e30974e71 Bug 18900: updater doesn't work on Linux (cannot find
 libraries)
 C 716067b4c679 Bug 11641: change TBB directory structure to be more like
 Firefox's
 C 4e0aed04f7f7 Bug 9173: Change the default Firefox profile directory to
 be TBB-relative.
 C 71a812c584aa Bug 19890: Disable installation of system addons
 C 17367581443f Bug 19273: Avoid JavaScript patching of the external app
 helper dialog.
 C 4da1d08fb2e2 Bug 18923: Add a script to run all Tor Browser specific
 tests
 C 612aefdabd9b Regression tests for #2874: Block Components.interfaces
 from content
 C 27fa6ab6fa2b Bug 18821: Disable libmdns for Android and Desktop
 C 40752ee655eb Bug 18800: Remove localhost DNS lookup in nsProfileLock.cpp
 C cc9862c27fd5 Bug 18799: disable Network Tickler
 C 5823d75f953a Bug 16620: Clear window.name when no referrer sent
 C 48b1c08e1fff Bug 16441: Suppress "Reset Tor Browser" prompt.
 C 6734d99f40b0 Bug 14392: Make about:tor behave like other initial pages.
 C 006dffb468ee Bug 2176: Rebrand Firefox to TorBrowser
 C 16a1bcef4e15 Bug 18995: Regression test to ensure CacheStorage is
 disabled in private browsing
 C c5b57b1bf1df Regression tests for "Omnibox: Add DDG, Startpage,
 Disconnect, Youtube, Twitter; remove Amazon, eBay, bing"
 C 6b35333f3a3a Regression tests for TB4: Tor Browser's Firefox preference
 overrides.
 C 93a8e5d1b523 Regression tests for Bug #2950: Make Permissions Manager
 memory-only
 C 1dc1a4f7fedc Bug 12620: TorBrowser regression tests folder
 C b6d8bf568ba6 Bug 14631: Improve profile access error msgs (strings).
 C 10ac5a7be31f Bug 14631: Improve profile access error messages.
 C 87cb0833ffdd Bug 14716: HTTP Basic Authentication prompt only displayed
 once
 C ccebcbb95267 Bug 13028: Prevent potential proxy bypass cases.
 C dfd201a96767 Bug 16439: remove screencasting code.
 F e0cb606a47ac Bug 2874: Block Components.interfaces from content
 C 58a737f021b2 Bug 12974: Disable NTLM and Negotiate HTTP Auth
 C fe1e6ce7f8d8 Bug 10280: Don't load any plugins into the address space.
 C 837f8e888cf5 Bug 8312: Remove "This plugin is disabled" barrier.
 C 1cbd34d3b0b8 Bug 3547: Block all plugins except flash.
 F 0e8dbb37c450 TB4: Tor Browser's Firefox preference overrides.
 C 4bdb543b0ae7 TB3: Tor Browser's official .mozconfigs.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26233#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online