[tor-bugs] #25164 [Applications/Tor Browser]: Reproducible Tor Browser for Android builds
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jul 30 09:38:59 UTC 2018
#25164: Reproducible Tor Browser for Android builds
----------------------------------------------+--------------------------
Reporter: sysrqb | Owner: tbb-team
Type: enhancement | Status: new
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, TorBrowserTeam201807 | Actual Points:
Parent ID: #26693 | Points:
Reviewer: | Sponsor:
----------------------------------------------+--------------------------
Comment (by boklm):
Replying to [comment:11 sisbell]:
> I've implemented building an Android apk with RBM at:
https://github.com/sisbell/tor-browser-build/tree/android
This is good work. Thanks!
Here are a few quick comments:
- the main ticket for integrating the android build into tor-browser-build
is not #25164 but #26693. This one is only for the reproducible part of it
(checking that multiple builds on multiple machines create the same
build).
- In the commit subject you should use `Bug XXXX:` (even if the ticket is
of type `enhancement`).
- to make it easier to review, you should split the commits in different
commits. I think one for adding stretch to debootstrap-image, for adding
android-toolchain, for adding the new platform definition to rbm.conf, for
fixing the rust build, for fixing the firefox build.
- should we call the target in rbm.conf `torbrowser-android-armv7` instead
of just `torbrowser-android`?
- `var/compiler` should be set to `android-toolchain` instead of `gcc`.
- `ndk.zip` should be included in `android-toolchain` so that is not
needed to download it from `projects/firefox/config`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25164#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list