[tor-bugs] #26520 [Applications/Tor Browser]: NoScript is broken with TOR_SKIP_LAUNCH=1 in ESR 60-based Tor Browser

[Tor Bug Tracker & Wiki]

#26520: NoScript is broken with TOR_SKIP_LAUNCH=1 in ESR 60-based Tor Browser
---------------------------------------------+-----------------------------
 Reporter:  gk                               |          Owner:  tbb-team
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Very High                        |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201807R  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by arthuredelstein):

 Replying to [comment:6 rustybird]:

 Thanks for testing! Addressing your comments in rearranged order:

 > (Slightly related, `noscript-control.js` has a guard against the
 `initialized` variable, but it's never set to `true`.)

 > `log(e.message);` -> `log(5, e.message);`

 Thanks for catching these two mistakes. Here's a revised patch that
 includes fixes for those:
 https://github.com/arthuredelstein/torbutton/commit/26520+1

 > Now it seems to fire too late - on first site load (not including
 about:tor). If that first loaded site contains JavaScript, it will be
 disabled there. Tested on e.g. https://enable-javascript.com

 > I tried with a line `log(5, "XXX sending");` added inside the
 `sendNoScriptSettings` function and noticed that both the first site load
 and moving the slider resulted in //multiple// messages to NoScript - not
 sure if that's a problem.

 I wasn't able to reproduce these two issues. I even tried setting https
 ://enable-javascript.com as the browser's homepage, but in every case the
 NoScript state seems to be set correctly. Do you still see these issues
 with the revised patch?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26520#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online