[tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Jul 17 13:46:34 UTC 2018
#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
-----------------------------------------------+---------------------------
Reporter: sysrqb | Owner: tbb-team
Type: task | Status:
| needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, TorBrowserTeam201807R | Actual Points:
Parent ID: #26531 | Points:
Reviewer: | Sponsor:
-----------------------------------------------+---------------------------
Comment (by gk):
I need to look with fresh eyes at commit
44c65b7904d8bf599345991942e0407af2030199 and commit
952f0ae78cc17f66624f3c634d831ff0aedc9692 tomorrow but the comments to the
remaining commits are:
commit a2c4e6217da42219327206508015ee24846907c4 -- probably okay (Any
reason the Facebook bg color (#ffecf0f3) did not get adjusted as done in
the original patch?)
commit 91eeee498b6733075d1de69d9f3568bfbffb5f05 -- not okay
I assume the resistfingerprinting related UA is not being used by Java
code automatically? If so, then we should hardcode that one and not a
custom one.
commit 14cefdc4bd90083e22ac263954a857d254b346a9 -- not okay
Indentation of the if-clauses
commit 94f9d2324391c5c18ac22a025b322a71adff3fcc -- okay
commit e1ed56fc4ed4a6cdcef8c692cb2d5f909174ddc4 -- okay
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26401#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list