[tor-bugs] #26692 [Core Tor/sbws]: sbws must not overwrite the bandwidth file, to avoid race conditions

Mon Jul 9 11:44:24 UTC 2018

#26692: sbws must not overwrite the bandwidth file, to avoid race conditions
-------------------------------+---------------------------------
     Reporter:  teor           |      Owner:  (none)
         Type:  defect         |     Status:  new
     Priority:  Medium         |  Milestone:  sbws 1.0 (MVP must)
    Component:  Core Tor/sbws  |    Version:
     Severity:  Normal         |   Keywords:
Actual Points:                 |  Parent ID:
       Points:                 |   Reviewer:
      Sponsor:                 |
-------------------------------+---------------------------------
 Instead, it must write a temporary file, and then rename the temporary
 file to the bandwidth file name.

 It should be a quick fix.

 For background, see:
 https://github.com/torproject/torspec/pull/21#discussion_r200971436

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26692>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online