[tor-bugs] #25928 [Core Tor/Tor]: Single DA in sandbox vs. PDS_ALLOW_SELF flag

[Tor Bug Tracker & Wiki]

#25928: Single DA in sandbox vs. PDS_ALLOW_SELF flag
---------------------------------------+-----------------------------------
 Reporter:  somlo                      |          Owner:  (none)
     Type:  defect                     |         Status:  needs_revision
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.5.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  tor-dirauth, test-network  |  Actual Points:
Parent ID:                             |         Points:
 Reviewer:  teor                       |        Sponsor:
---------------------------------------+-----------------------------------

Comment (by somlo):

 Replying to [comment:10 teor]:
 > Thanks for the patch, but the condition activates PDS_ALLOW_SELF on
 *any* relay or client with a single configured DirAuth.
 >
 > We only want to activate PDS_ALLOW_SELF if *this* relay is the single
 dirauth:
 >
 > Replying to [comment:5 teor]:
 > > Here's what we need to do to make it complete:
 > > * add a condition to the if statement: "this relay must be the only
 configured directory authority"
 > > …
 > > I think you'll want to compare the relay fingerprint field from
 router_get_my_routerinfo(), to the relay fingerprint in the only entry in
 the list.

 But that already happens, when router_pick_dirserver_generic() calls
 router_pick_trusteddirserver_impl(). The latter *consumes* the
 PDS_ALLOW_SELF flag to determine whether to allow "me &&
 router_digest_is_me(d->digest)" to be a candidate DA, which IMHO takes
 care of your requirement above. Please check out comment #6 above, and
 tell me what I'm missing -- Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25928#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online