[tor-bugs] #26522 [Core Tor/Tor]: strncat() without bounds

Tue Jul 3 14:10:03 UTC 2018

#26522: strncat() without bounds
----------------------------------------+----------------------------------
 Reporter:  Dhiraj                      |          Owner:  rl1987
     Type:  defect                      |         Status:  needs_review
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.3.5.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Major                       |     Resolution:
 Keywords:  security-low, 035-proposed  |  Actual Points:
Parent ID:                              |         Points:
 Reviewer:                              |        Sponsor:
----------------------------------------+----------------------------------

Comment (by rl1987):

 `strncat()` was introduced pretty recently in
 a969ce464dc23db39725a891d60537f3d3e51b50.

 I updated my patch to use `snprintf()` from libc.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26522#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online