[tor-bugs] #25386 [Core Tor/Tor]: Link Rust Tests to C Dependencies in Tor (allow integration testing from Rust to C)
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Jul 3 01:14:21 UTC 2018
#25386: Link Rust Tests to C Dependencies in Tor (allow integration testing from
Rust to C)
-------------------------------------------------+-------------------------
Reporter: Hello71 | Owner: nickm
Type: defect | Status:
| accepted
Priority: High | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.3.1-alpha
Severity: Normal | Resolution:
Keywords: rust, tor-test, 033-backport, | Actual Points:
review-group-34, 034-triage-20180328, |
034-included-20180401 |
Parent ID: | Points: 3
Reviewer: isis | Sponsor:
| SponsorQ
-------------------------------------------------+-------------------------
Comment (by isis):
Replying to [comment:71 nickm]:
> > Can we make it optional?
>
> Sure -- but someone will need to come up with a mechanism that works and
doesn't cause too much pain.
So 1.27 is now the stable rust, and it [https://github.com/rust-
lang/rust/pull/49956/commits/1a0d7a8207907e2459db8df72a8f604cdcc8285f does
include] the `-C` option for rustdoc.
I'm not exactly understanding which part is supposed to be optional? Is
it:
1. Passing the same flags as we pass to `RUSTFLAGS` to the `rustdoc -C`
should be optional?
2. Or, compiling tests which expect to use C code should be optional? (If
so, see #26398.)
3. Or something else?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25386#comment:73>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list