[tor-bugs] #24902 [Core Tor/Tor]: Denial of Service mitigation subsystem

[Tor Bug Tracker & Wiki]

#24902: Denial of Service mitigation subsystem
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ddos, tor-relay, review-group-30,    |  Actual Points:
  029-backport, 031-backport, 032-backport,      |
  review-group-31                                |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 {{{
   /* Number of allowed circuit rate that is this value is refilled at a
 rate
    * defined by the consensus plus a bit of random. It is decremented
 every
    * time a new circuit is seen for this client address and if the count
 goes
    * to 0, we have a positive detection. */
   uint32_t circuit_bucket;
 }}}

 (a) should be "Number of allocated circuits remaining for this address",
 i.e. it's not a rate, it's a size.

 (b) What's this about "plus a bit of random"? :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24902#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online