[tor-bugs] #25024 [Core Tor/Tor]: Add optional spell check to makefile to check for typos in tor source code.

[Tor Bug Tracker & Wiki]

#25024: Add optional spell check to makefile to check for typos in tor source code.
--------------------------+------------------------------------
 Reporter:  fristonio     |          Owner:  alison
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Low           |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Minor         |     Resolution:
 Keywords:  tor-comment   |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  new => needs_revision
 * keywords:   => tor-comment
 * points:   => 0.5
 * component:  Community => Core Tor/Tor
 * milestone:   => Tor: 0.3.4.x-final


Comment:

 Thanks for this patch. I missed it because this ticket was in the wrong
 component.
 (And using @teor doesn't work -  you need to add "teor" to the CC field.)

 Code review:

 The makefile should check for misspell at runtime, not configure time.
 Otherwise, a user who reads your message and installs misspell will get
 very confused. Try the shell command called "command". Or look how it's
 done elsewhere in the makefile.

 Also, markdown links don't work in most terminals. You are better to just
 link once at the end of the log message:
 {{{
 misspell(http://github.com/client9/misspell)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25024#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online