[tor-bugs] #22739 [Core Tor/Tor]: Make routerinfo_t and routerstatus_t addresses immutable; store overrides in node_t

[Tor Bug Tracker & Wiki]

#22739: Make routerinfo_t and routerstatus_t addresses immutable; store overrides
in node_t
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * cc: teor (added)
 * status:  accepted => needs_review
 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


Comment:

 I've started a branch here as `feature22739`.  I've taken the approach
 above, but only used the "rename the field" trick to identify places that
 might need a change.  I've marked those with XXXX comments.

 This isn't done, but I wouldn't mind some feedback on this approach.

 Adding teor to cc because he's looked at this code a lot.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22739#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online