[tor-bugs] #24914 [Core Tor/Tor]: Maybe make relay_digest_matches() not use tor_malloc()

[Tor Bug Tracker & Wiki]

#24914: Maybe make relay_digest_matches() not use tor_malloc()
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  nickm
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-relay     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  dgoulet       |        Sponsor:
--------------------------+------------------------------------

Comment (by dgoulet):

 Replying to [comment:6 nickm]:
 > The rationale for not using crypto_digest_assign() here is that
 crypto_digest_t is opaque, so it can't be stack-allocated.  Does that seem
 plausbile?
 >
 > I agree that the memset should be memwipe.

 Ah indeed. Ok makes sense for both. I'm not sure we need to zero it here
 also but maybe it is security related so no strong opinion.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24914#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online