[tor-bugs] #25008 [Core Tor/Tor]: Call protocol_list_supports_protocol less often to save time and allocation

[Tor Bug Tracker & Wiki]

#25008: Call protocol_list_supports_protocol less often to save time and allocation
-------------------------+-------------------------------------------------
     Reporter:  nickm    |      Owner:  nickm
         Type:  defect   |     Status:  assigned
     Priority:  Medium   |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  032-backport? malloc performance
     Severity:  Normal   |  protover
Actual Points:           |  Parent ID:  #23777
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 This function appeared on the heap profile of #23777, and there's no
 reason it should have done so.  It appears to have been getting called by
 circuit_extend(), which suggests that we have some dodgy logic somewhere.
 I blame node_supports_ed25519_link_allocation.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25008>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online