[tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory deterministic
-----------------------------+-------------------------------
 Reporter:  karsten          |          Owner:  iwakeh
     Type:  enhancement      |         Status:  accepted
 Priority:  High             |      Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-2018     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+-------------------------------

Comment (by iwakeh):

 Replying to [comment:37 karsten]:
 > Replying to [comment:36 iwakeh]:
 > > The list of exit_addresses is one more data item in onionoo's details
 documents that is depending on the current system time.  Depending on the
 current time the addresses are added or omitted to the stored collection
 (cf.
 [https://gitweb.torproject.org/user/karsten/onionoo.git/tree/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java?h=task-16513-2#n805
 NodeDetailsStatusUpdater]).  Could the validAfter time of the latest
 consensus processed be a replacement for the system time?
 >
 > Yes. We should probably do that. I haven't tried it out yet, nor have I
 looked around for similar places where we're depending on system time
 there.
 >
 > However! That's a different issue. It's about making the '''update'''
 step less dependent on things like system time, though we won't be able to
 make it fully deterministic. Still a good thing to do. But it's different
 from making the '''write''' step deterministic where we're taking a
 `status/` directory as input and writing files to the `out/` directory.
 Should we collect this idea on a new ticket, like, "Make updating status
 files independent of system time"?

 Oh, I took this ticket as meaning 'Make results from Onionoo
 deterministic', but writing and updating are different concerns.  Will
 open a new ticket (rather with the meaning I perceived) and check for more
 issues in the update process while continuing the review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16513#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online