[tor-bugs] #18918 [Core Tor/Tor]: Clarify directory and ORPort checking functions

[Tor Bug Tracker & Wiki]

#18918: Clarify directory and ORPort checking functions
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  easy, doc, code, refactor            |  Actual Points:
  technical-debt tor-relay                       |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Oh, you left out a few:

 decide_to_advertise_begindir() -> router_should_advertise_begindir()

 consider_testing_reachability():

 Maybe we could split this into a boolean function that doesn't change
 state: router_should_check_reachability().
 And a function that calls that function and changes state:
 router_do_reachability_checks().

 You might also want to check the code and documentation in these
 functions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18918#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online