[tor-bugs] #24966 [Core Tor/Tor]: Silence warnings for circuits created from controller

[Tor Bug Tracker & Wiki]

#24966: Silence warnings for circuits created from controller
--------------------------+------------------------------------
 Reporter:  tom           |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  regression?   |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * keywords:   => regression?
 * points:   => 0.5
 * milestone:   => Tor: 0.3.4.x-final


Comment:

 There are a few bugs here:
 * circuit_purpose_may_omit_guard() should probably return 1 for
 CIRCUIT_PURPOSE_CONTROLLER (bug on 0.3.0.1-alpha)
 * Maybe we should unify pathbias_should_count() and
 circuit_purpose_may_omit_guard(), or at least make them more consistent
 (bug on 0.3.0.1-alpha)

 But the underlying bug is that pathbias_should_count() wants to know if
 the circuit was created by a controller. There is no flag for this:
 instead, it checks if the circuit has a controller purpose right now (bug
 on 0.2.4).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24966#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online