[tor-bugs] #22428 [Metrics/CollecTor]: Add webstats module

[Tor Bug Tracker & Wiki]

#22428: Add webstats module
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_revision
 Priority:  High               |      Milestone:  CollecTor 1.5.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  metrics-2018       |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 I just reviewed the last commits (086e904, d7a2835, 45dd764) altogether.
 Here's what I found:

  - We'll have to clean up `CHANGELOG.md` before this branch gets merged.
 It contains duplicate/overlapping entries for the new changes. I can do
 that as part of merging.
  - Let's also not forget to release metrics-lib 2.2.0 before merging this
 branch and updating to 2.2.0 rather than 2.2.0-dev. I can do that as part
 of merging, too.
  - New copyrights should be changed to 2018. I can do this, too.
  - Can I ask you to reference all member attributes or methods with
 `this.`? I know it's syntactically irrelevant for the compiler, but for me
 as a human being it improves readability a lot.
  - There's a line in `SanitizeWeblogs.java` , namely `SortedSet<LocalDate>
 sorted = new TreeSet();`, which is missing a pair of `<>`. This is the
 only actual code change I have, which is why I didn't include this change
 in a patch.
  - The default values `WebstatsPeriodMinutes = 31` and
 `WebstatsOffsetMinutes = 0` seem a bit unusual. Wouldn't it make more
 sense to start with an offset of 1 minute and then run every 30 minutes?
 And regardless of the period being unusual, isn't that far too often? How
 about 360 as period and, say, 31 as offset?
  - Other than that, I'd say let's try it out when you say it's ready. I
 think that's more efficient to find remaining bugs than re-reading and
 tweaking the code. Just let me know when I should do some tests.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22428#comment:46>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online