[tor-bugs] #23101 [Core Tor/Tor]: Predict and build specific HS purpose circuits (rather than GENERAL)

[Tor Bug Tracker & Wiki]

#23101: Predict and build specific HS purpose circuits (rather than GENERAL)
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, tor-guard, guard-discovery-  |  Actual Points:
  prop247-controller, review-group-27, review-   |
  group-30                                       |
Parent ID:  #13837                               |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 My major thought on this one:

 It's never the case that we have preemptive old-style onion service
 circuits and also preemptive vanguard-style onion service circuits going
 on at the same time, right?

 That is, with the current design, we have two things supported in the code
 at the same time: a C_GENERAL is_internal circuit, and an HS_VANGUARDS
 is_internal circuit. And which one we make, and expect to use, is
 controlled by whether we have one (or both) of the HSLayerXGuards options
 set.

 So a much simpler design could be: if it's C_GENERAL but is_internal is
 set, then either build it like a 3-hop vanguard circ if you're using
 vanguards, else build it like a normal 3-hop onion service circ.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23101#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online