[tor-bugs] #24927 [Core Tor/Tor]: if (n_chan_id) in circuit_build_failed() can't fail

[Tor Bug Tracker & Wiki]

#24927: if (n_chan_id) in circuit_build_failed() can't fail
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.4.4-alpha
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 I think this bug is harmless, in that we don't actually rely on
 circ->cpath->extend_info->identity_digest being non-zero for the things
 that we call.

 But it would be good to get a second set of eyes on this conclusion. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24927#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online