[tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

[Tor Bug Tracker & Wiki]

#16513: Make writing of the out/ directory from the status/ directory deterministic
-----------------------------+-------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  enhancement      |         Status:  needs_review
 Priority:  High             |      Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-2018     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+-------------------------------
Changes (by karsten):

 * status:  merge_ready => needs_review


Comment:

 Thanks for checking. I just added one small (but important) fixup commit
 ([https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-16513-2&id=c9157949039c6793c2bc36a10a3e561575b40530
 c915794]) and another big (and also important) refactoring commit
 ([https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-16513-2&id=699d82613fcd20c5e7b29a6a1082a2d5058c1ab8
 699d826]) to my branch. That second commit reduces code duplication by a
 lot, which I think is an important step towards making this code more
 maintainable by other people than me in the future.

 However, I'm running out of time here. The new code is way better
 documented than usual, it compiles, checkstyle doesn't have complaints,
 and all tests pass, including new ones. But I can't spend another day on
 running system tests, and I do expect the output to be somewhat different
 from current output. But each difference needs investigation, and maybe
 the old output was wrong and the new output is right.

 iwakeh or maybe irl, can I ask either of you to take over here? Reviewing
 and testing this code is not a trivial task, and it will almost certainly
 take longer than a few hours. But I could imagine it's a good way to dive
 deeper into this part of Onionoo, and at the same time ensure that this
 code will be more readable.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16513#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online