[tor-bugs] #24423 [Core Tor/Tor]: Fix STACK warnings in Tor

[Tor Bug Tracker & Wiki]

#24423: Fix STACK warnings in Tor
----------------------------------------------+----------------------------
 Reporter:  nickm                             |          Owner:  nickm
     Type:  defect                            |         Status:
                                              |  merge_ready
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.3.3.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  review-group-27, review-group-29  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:  catalyst                          |        Sponsor:
----------------------------------------------+----------------------------

Comment (by catalyst):

 I think `ALL_BUGS_ARE_FATAL` is good to use with STACK because we use it
 with other static analysis tools for similar reasons.  (It helps tools
 figure out what code is intentionally dead and decreases the noise level.)

 I kind of understand why the new error is happening with
 `ALL_BUGS_ARE_FATAL` but I can't describe it well yet.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24423#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online