[tor-bugs] #24421 [Applications/Tor Browser]: "Temporarily allow all this page" and uploads get inherited when New Identity is chosen.

[Tor Bug Tracker & Wiki]

#24421: "Temporarily allow all this page" and uploads get inherited when New
Identity is chosen.
----------------------------------------------+--------------------------
 Reporter:  cypherpunks                       |          Owner:  tbb-team
     Type:  defect                            |         Status:  new
 Priority:  High                              |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Major                             |     Resolution:
 Keywords:  tbb-newnym, TorBrowserTeam201801  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+--------------------------

Comment (by mcs):

 After some more debugging, Kathy and I have learned that the root of the
 problem is that some NoScript data structures are not correctly
 synchronized between the chrome process and the content process when e10s
 is enabled. Specifically, after "Temporarily allow all this page" is done
 for a site, one of the `Main.js` instances does not record the site inside
 `this.tempSites`. Later when `eraseTemp()` is called to remove all
 temporary sites, the site is not removed.

 I don't know if it is the correct fix, but this bug disappeared after we
 changed `ns.bootstrap` to include `setTemp` in the list of functions
 included in the `IPC.autoSync()` call:
 {{{
     try {
       IPC.autoSync(this, "Main", ["setJSEnabled", "setTemp", "eraseTemp",
 "allowObject", "resetAllowedObjects", "shutdown"]);
     } catch (e) {
 }}}

 Giorgio, can you take it from here?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24421#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online