[tor-bugs] #24905 [Core Tor/Tor]: Remove redundant connection_or_digest_is_known_relay() from CHANNEL_IS_CLIENT

[Tor Bug Tracker & Wiki]

#24905: Remove redundant connection_or_digest_is_known_relay() from
CHANNEL_IS_CLIENT
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core     |    Version:  Tor: 0.3.1.1-alpha
  Tor/Tor                |
     Severity:  Normal   |   Keywords:  refactor, redundant, technical-debt
Actual Points:           |  Parent ID:  #23423
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 After we fix #24898, we should fix this macro as well:
 {{{
 #define CHANNEL_IS_CLIENT(chan, options) \
   (!public_server_mode((options)) || channel_is_client(chan) || \
       !connection_or_digest_is_known_relay((chan)->identity_digest))
 }}}

 And we should rename it to something like
 CHANNEL_IS_CLIENT_AT_EITHER_END() to fix #22717.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24905>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online