[tor-bugs] #24895 [Core Tor/Tor]: MAX_REND_FAILURES is 1, but we will try three times

[Tor Bug Tracker & Wiki]

#24895: MAX_REND_FAILURES is 1, but we will try three times
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  032-backport, 031-backport,          |  Actual Points:
  030-backport, 029-backport, 025-backport       |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * cc: dgoulet (removed)
 * status:  needs_review => merge_ready
 * keywords:  032-backport => 032-backport, 031-backport, 030-backport,
     029-backport, 025-backport
 * reviewer:   => dgoulet


Comment:

 We'll need to backport this back to 025... Shouldn't be complicated.

 I agree with Roger here that ideally we would increment the failure count
 much earlier that is before the check is done on the failure count.

 But this is simple enough for now to backport far away and it has a
 comment explaining why so we aren't lost about this gymnastic.

 This does affect both v2 and v3 where the code changed in 032 but not the
 logic and code flow.

 lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24895#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online