[tor-bugs] #24423 [Core Tor/Tor]: Fix STACK warnings in Tor

[Tor Bug Tracker & Wiki]

#24423: Fix STACK warnings in Tor
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-27  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  catalyst         |        Sponsor:
-----------------------------+------------------------------------

Comment (by catalyst):

 You're saying STACK is warning about the `tor_fragile_assert()` in
 `networkstatus_get_flavor_name()` being eliminated as dead code as a
 consequence of a buffer overflow not occurring when looping over
 N_CONSENSUS_FLAVORS?  Is the problem partly that STACK doesn't see
 `tor_fragile_assert()` as intrinsically unreachable because by default
 it's nonfatal?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24423#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online