[tor-bugs] #23975 [Core Tor/Tor]: Make node_get_pref_ipv6_orport() check addresses in the right order

[Tor Bug Tracker & Wiki]

#23975: Make node_get_pref_ipv6_orport() check addresses in the right order
-----------------------------------+------------------------------------
 Reporter:  teor                   |          Owner:  teor
     Type:  defect                 |         Status:  needs_revision
 Priority:  Medium                 |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor           |        Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal                 |     Resolution:
 Keywords:  ipv6, review-group-28  |  Actual Points:  2
Parent ID:  #20916                 |         Points:  1
 Reviewer:  nickm                  |        Sponsor:  SponsorV-can
-----------------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision
 * reviewer:   => nickm


Comment:

 Looks plausible!  It's good to see so much complexity removed here.

 I think we already merged #23736, so I'll assume we rebase before the
 merge to drop 189127acf2014907eac747e25d32668741dc2c5e ?

 Let's add a comment to document SET_IPV6_AP.  We should ''especially''
 document that it conditionally returns, possibly by renaming it: macros
 that alter control flow should make it obvious.

 Other than that, I think I like this.  How is the test coverage for all
 the functions in policies.c that we modify?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23975#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online