[tor-bugs] #24733 [Core Tor/Tor]: Loading ifc.ifc_buf using the new tor_free() causes undefined behaviour on x86_64 macOS

[Tor Bug Tracker & Wiki]

#24733: Loading ifc.ifc_buf using the new tor_free() causes undefined behaviour on
x86_64 macOS
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  address-sanitizer, unexpected-       |  Actual Points:  0.1
  consequences                                   |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  merge_ready => needs_review


Comment:

 catalyst and I talked about this at the patch party.

 Instead of merging this branch, we think we should revert the evaluate-
 once change 1d348989b08a3d3c50dfa2600a5e5e2f61fb2b4a, to fix this issue.

 Then we can open a ticket to decide if evaluate once is needed.
 (Unfortunately, we could not find any clang or gcc warnings about macro
 arguments with side-effects. Surely there has to be one?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24733#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online