[tor-bugs] #21074 [Core Tor/Tor]: setrlimit fails OSX Sierra

[Tor Bug Tracker & Wiki]

#21074: setrlimit fails OSX Sierra
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  nickm
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.6.7
 Severity:  Normal                               |     Resolution:
 Keywords:  OSX Sierra setrlimit, tbb-needs,     |  Actual Points:
  031-backport                                   |
Parent ID:                                       |         Points:  2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:31 Dbryrtfbcbhgf]:
 > Replying to [comment:30 teor]:
 > > Apparently some users encountered this issue after a 10.11.6 security
 update:
 > > https://tor.stackexchange.com/questions/16033/tor-unexpectedly-exited-
 this-might-be-due-to-a-bug-in-tor-itself-another-progr
 > >
 > > And raising file descriptors using sudo fixes it in some cases.
 > >
 > > So yes, I think we should presume that some configurations cause
 setrlimit to fail, and change tor to make setrlimit failures non-fatal.
 > > (I have multiple Tor Browser instances on admin and non-admin users,
 so it's not a simple permissions issue.)
 > This user noticed something that may be the cause of the bug.
 > https://trac.torproject.org/projects/tor/ticket/24764#comment:20
 > https://trac.torproject.org/projects/tor/ticket/24764#comment:21

 Calling launchctl to set the file limit per-user is the wrong way for
 JBridgeM to make this change. It should either:
 * create a separate user and set the limit on that user, or
 * set the limit on its own process, rather than all processes run by the
 user.

 But as far as Tor is concerned, this is something that will come up in
 some users' configurations, so we should make the setrlimit call non-
 fatal, and test using the same commands as:

 https://trac.torproject.org/projects/tor/ticket/24764#comment:21

 to make sure we have caught all the possible failure modes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21074#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online