[tor-bugs] #22689 [Core Tor/Tor]: hs: Stop rend and intro points being used as single hop proxies

[Tor Bug Tracker & Wiki]

#22689: hs: Stop rend and intro points being used as single hop proxies
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  dgoulet
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  relay-safety  |  Actual Points:
Parent ID:  #17945        |         Points:  0.5
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------

Comment (by dgoulet):

 Replying to [comment:12 teor]:
 > I'll review this later today, after I get some Rust done.
 >
 > Do we want a consensus parameter to block Tor2web at Intros, like the
 one at Rendezvous?
 > I think the answer is "yes, but not on by default, and not on right now,
 and maybe just in 0.3.4".
 > I opened #25371 to do it in a separate task.

 Yes I think ultimately (hopefully 034 imo), we come down to rejecting
 single hop client for any part of the HS dance (single onion or not). Lets
 open a ticket for that at the RDV?

 I've modified the branch based on asn's comment to merge the suitable
 functions into one. I've renamed the function also to reflect a bit more
 what it is doing.

 See fixup `216c754e6f`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22689#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online