[tor-bugs] #25095 [Core Tor/Tor]: Update dir-spec.txt with recent consensus param additions
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Feb 20 14:34:09 UTC 2018
#25095: Update dir-spec.txt with recent consensus param additions
-------------------------------+------------------------------------
Reporter: arma | Owner: dgoulet
Type: task | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-spec, tor-dos | Actual Points:
Parent ID: | Points:
Reviewer: ahf | Sponsor:
-------------------------------+------------------------------------
Changes (by ahf):
* status: needs_review => needs_revision
* reviewer: => ahf
Comment:
I think the patch looks good, I have two questions:
1. `DoSCircuitCreationBurst` and `DoSCircuitCreationRate` seems related.
Is `DoSCircuitCreationRate` also per Client IP address or not? Maybe that
is worth addressing explicitly if it is.
2. `DoSCircuitCreationDefenseType` is a bit vaguely defined here -- what
are the possible values this could have? From the other entries I think
it's possible to deduct the data-type, but not for this one.
Other than that it looks good.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25095#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list