[tor-bugs] #25260 [Applications/Tor Launcher]: Merge mozbuild files into tor-launcher.git
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Feb 20 08:30:36 UTC 2018
#25260: Merge mozbuild files into tor-launcher.git
---------------------------------------+-----------------------
Reporter: sysrqb | Owner: brade
Type: enhancement | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Launcher | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #24856 | Points:
Reviewer: | Sponsor:
---------------------------------------+-----------------------
Comment (by cypherpunks):
Replying to [comment:6 sysrqb]:
> I dug a little deeper on this, and I build the patch from mozilla-
central. It seems some changes were introduced since ESR52. 1) At build
time all system addons are added into a file,
IDs of add-ons
> and that file is checked at application startup[0], so we won't be able
to simply copy the extension into browser/features/ post-build,
That's the goal [0] was created for.
> we'll need to modify this file too [1].
It's auto-generated, no?
> This is the situation on desktop. On mobile, I don't see where this file
is created, so right now I think "features" are broken on mobile. I'll dig
into this some more.
If you add Tb and Tl to "features", they'll become part of firefox build,
no post-build modifications are required.
> [0] https://bugzilla.mozilla.org/show_bug.cgi?id=1348981
> [1]
obj-*/dist/bin/browser/chrome/browser/content/browser/built_in_addons.json
> [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1277920
Generally, as Tb and Tl don't require updates, the better way to integrate
them is mentioned in
https://bugzilla.mozilla.org/show_bug.cgi?id=1212059#c5
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25260#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list