[tor-bugs] #25055 [Core Tor/Tor]: string_is_valid_hostname() returns true for IPv4 addresses

[Tor Bug Tracker & Wiki]

#25055: string_is_valid_hostname() returns true for IPv4 addresses
-------------------------------+------------------------------------
 Reporter:  teor               |          Owner:  (none)
     Type:  defect             |         Status:  needs_revision
 Priority:  Medium             |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor       |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  IPv6 IPv4 tor-dns  |  Actual Points:
Parent ID:                     |         Points:  1
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------------

Comment (by arma):

 Replying to [comment:9 teor]:
 > 1. If it is a valid IPv4 or IPv6 address, it is not a hostname

 I don't understand why we're making this complicated.

 This string_is_valid_hostname() thing is only used in our socks handshake,
 right?

 If we define hostname to be "anything that is a valid destination", then
 everything becomes simple, right?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25055#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online