[tor-bugs] #25290 [Core Tor/Tor]: refactor to use should_record_bridge_info() more

[Tor Bug Tracker & Wiki]

#25290: refactor to use should_record_bridge_info() more
------------------------------+--------------------------------
     Reporter:  arma          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  easy
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 We have this function
 {{{should_record_bridge_info}}}
 which simply checks
 {{{options->BridgeRelay && options->BridgeRecordUsageByCountry}}}.

 But in geoip_note_client_seen(), where we just added the DoS mitigation
 stuff, we don't use the function, instead choosing to check the variables
 directly. We make the same choice in the options_need_geoip_info()
 function.

 We should refactor things so we use the function in all cases.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25290>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online