[tor-bugs] #24658 [Core Tor/Tor]: Split/refactor crypto.h into smaller separate modules

[Tor Bug Tracker & Wiki]

#24658: Split/refactor crypto.h into smaller separate modules
-------------------------------------------------+-------------------------
 Reporter:  isis                                 |          Owner:
                                                 |  ffmancera
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-crypto, refactor, review-        |  Actual Points:
  group-32                                       |
Parent ID:                                       |         Points:
 Reviewer:  isis                                 |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------
Changes (by ffmancera):

 * status:  needs_revision => needs_review


Comment:

 Thanks :-)

 > Maybe remove the `crypto_curve25519.h` included in `crypto_rsa.c`?

 I removed the `crypto_curve25519.h` included in `crypto_rsa.h` in order to
 not include useless modules everywhere. If you don't agree, let me know
 and I will remove it from `crypto_rsa.c`.

 > Why didn't `crypto_pk_obsolete_public_hybrid_encrypt()` or
 `crypto_pk_obsolete_private_hybrid_decrypt()` move from `crypto.[ch]` to
 `crypto_rsa.[ch]`?

 I thought it could fit better into the cipher module but, after think more
 about it, it should be in rsa module.

 Everything done in the
 [https://github.com/ffmancera/tor-1/tree/bug24658-xof_digest
 bug24658-xof_digest] branch! :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24658#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online