[tor-bugs] #25184 [Metrics/Consensus Health]: consensus health says that signatures are sha1, but the microdesc consensus actually uses sha256 (was: consensus health says that signatures are sha1, but they're actually sha256)

[Tor Bug Tracker & Wiki]

#25184: consensus health says that signatures are sha1, but the microdesc consensus
actually uses sha256
--------------------------------------+---------------------
 Reporter:  teor                      |          Owner:  tom
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Metrics/Consensus Health  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+---------------------

Old description:

> I guess this was accidentally hard-coded somewhere?

New description:

 ~~I guess this was accidentally hard-coded somewhere?~~

--

Comment (by teor):

 This does not appear to be a stem bug.

 ns consensuses have sha1:
 {{{
 directory-signature 0232AF901C31A04EE9848595AF9BB7620D4C5B2E
 E66AE3C828CCAA8A765620B2750DD6257C9A52D4
 }}}

 microdesc consensuses have sha256:
 {{{
 directory-signature sha256 0232AF901C31A04EE9848595AF9BB7620D4C5B2E
 E66AE3C828CCAA8A765620B2750DD6257C9A52D4
 }}}

 I didn't check both consensus flavours - I only checked microdesc
 consensuses.
 And I guess consensus health only checks ns consensuses.

 Can we modify it to check both?
 That might mean changing the format of the signature table a little.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25184#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online