[tor-bugs] #25247 [- Select a component]: mochitest failures for #23104 patch

[Tor Bug Tracker & Wiki]

#25247: mochitest failures for #23104 patch
------------------------------------------------+------------------------
 Reporter:  arthuredelstein                     |          Owner:  (none)
     Type:  defect                              |         Status:  new
 Priority:  Medium                              |      Milestone:
Component:  - Select a component                |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tbb-fingerprinting, tbb-regression  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+------------------------

Comment (by igt0):

 I was not able to reproduce, however, I think the issue is related to
 pixel density + font rendering. The test sets the font-size to 16.5px,
 however in the failures you posted, the css font size was rounded up to
 17px by the browser.

 That said, I tried a different approach:

 https://trac.torproject.org/projects/tor/attachment/ticket/25247/0001-bug-25247
 -Update-bug23104-test-to-be-DPI-independent.patch

 Could you give a try?

 Replying to [ticket:25247 arthuredelstein]:
 > I ran the mochitests for the #23104 patch on our tor-
 browser-52.6.0esr-8.0-2 branch on Debian GNU/Linux 9.1 and I ran into the
 following failures:
 >
 > {{{
 > Passed: 3
 > Failed: 3
 > Todo: 0
 > failed | Line Height validation - got 20.4, expected 19.8
 > failed | Line Height validation - got 20.4, expected 19.8
 > failed | Line Height validation - got 20.4, expected 19.8
 > passed | Line Height validation
 > passed | Line Height validation
 > passed | Line Height validation
 > }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25247#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online