[tor-bugs] #22739 [Core Tor/Tor]: Make routerinfo_t and routerstatus_t addresses immutable; store overrides in node_t

[Tor Bug Tracker & Wiki]

#22739: Make routerinfo_t and routerstatus_t addresses immutable; store overrides
in node_t
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-31  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 I think the overall approach, in these two patches, is sensible and should
 clean-up this code a lot. The removed code in the first patch is quite
 some spaghetti.

 Small nit:

 {{{
 tor_addr_port_t override_orport;
 }}}

 in `or.h` is missing a documentation string.

 I think this code is good, but I'm marking this ticket as needing revision
 because of the many XXX's in the second patch.

 Maybe Teor have some additional feedback here too?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22739#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online