[tor-bugs] #18918 [Core Tor/Tor]: Clarify directory and ORPort checking functions

[Tor Bug Tracker & Wiki]

#18918: Clarify directory and ORPort checking functions
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  easy, doc, code, refactor,           |  Actual Points:
  technical-debt, tor-relay, review-group-31     |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by ffmancera):

 Replying to [comment:14 nickm]:


 > Only one thing I'm seeing here: the log message in
 `router_should_be_directory_server()` will sometimes refer to
 "DirDirectory Service support".

 So should we introduce "Directory/DirDirectory" into log messages? Is
 there any other way to point out when it's each one?.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18918#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online