[tor-bugs] #25127 [Core Tor/Tor]: Rust implementation of protover_get_supported_protocols() leaks memory

[Tor Bug Tracker & Wiki]

#25127: Rust implementation of protover_get_supported_protocols() leaks memory
----------------------------------+------------------------------------
 Reporter:  nickm                 |          Owner:  isis
     Type:  defect                |         Status:  reopened
 Priority:  Medium                |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor          |        Version:  Tor: 0.3.2.1-alpha
 Severity:  Normal                |     Resolution:
 Keywords:  rust, protover, leak  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:  SponsorM
----------------------------------+------------------------------------
Changes (by isis):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:21 nickm]:
 > oh!  I hadn't known that a ffi-panic would be UB.  We should fix that
 too, if there's an easy way around it.

 Okay, it's pretty easy since—wherever else in the protover code that stuff
 can go wrong—we just return/use empty strings, so we could just change the
 `unwrap()`s to `unwrap_or("")`. There is a patch in my `bug25127_redux`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug25127_redux
 branch].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25127#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online