[tor-bugs] #25178 [Applications/Tor Browser]: Running 'make testbuild' does not build the windows-x86_64 version
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Feb 8 14:41:19 UTC 2018
#25178: Running 'make testbuild' does not build the windows-x86_64 version
------------------------------------------+----------------------
Reporter: boklm | Owner: tbb-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Keywords: tbb-rbm
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
------------------------------------------+----------------------
When running `make testbuild` we don't build anymore the Window 64
version.
I think this is caused by the change from commit
dc51005d4944d6be9ca1c06331c3f9ee1cee51fc:
{{{
diff --git a/projects/release/config b/projects/release/config
index e53ea43..f0d95c7 100644
--- a/projects/release/config
+++ b/projects/release/config
@@ -29,7 +29,7 @@ targets:
torbrowser-windows-i686: 1
torbrowser-windows-x86_64:
var:
- torbrowser-windows-x86_64: 1
+ torbrowser-windows-x86_64: '[% c("var/alpha") || c("var/nightly")
%]'
torbrowser-osx-x86_64:
var:
torbrowser-osx-x86_64: 1
}}}
The `testbuild` build is started with:
{{{
$(rbm) build release --target testbuild --target torbrowser-all
}}}
At this point (in projects/release), `var/alpha` or `var/nightly` is not
yet set, so `var/torbrowser-windows-x86_64` is false.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25178>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list