[tor-bugs] #25127 [Core Tor/Tor]: Rust implementation of protover_get_supported_protocols() leaks memory

[Tor Bug Tracker & Wiki]

#25127: Rust implementation of protover_get_supported_protocols() leaks memory
----------------------------------+------------------------------------
 Reporter:  nickm                 |          Owner:  isis
     Type:  defect                |         Status:  assigned
 Priority:  Medium                |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  rust, protover, leak  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------------

Comment (by isis):

 Hi! I have
 [https://github.com/isislovecruft/tor/commit/7ea9e080c58f16fecefa5a0a20406635a2034366
 a patch] to fix that leak, but then noticed something was still leaking,
 and then noticed teor's comment above.  The TravisCI [https://travis-
 ci.org/isislovecruft/tor/builds/337845800 is passing again] at least, so
 that's nice.

 I'll fix the rest of the leak tomorrow and add it to the `bug25127` branch
 and try to make some utilities/abstractions for working with static
 string-like things better between Rust and C.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25127#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online