[tor-bugs] #21716 [Core Tor/Tor]: Avoid recursive call to routerlist_remove_old_routers via router_rebuild_store

[Tor Bug Tracker & Wiki]

#21716: Avoid recursive call to routerlist_remove_old_routers via
router_rebuild_store
--------------------------+------------------------------------
 Reporter:  anstein       |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy intro    |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 We need to pick one of these functions, and make it call the other one
 using a loop. It's much simpler to do it that way.

 Here's some background reading on recursion and iteration (loops). It
 might help explain why we prefer loops:
 https://en.m.wikipedia.org/wiki/Recursion_(computer_science)#Recursion_versus_iteration

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21716#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online