[tor-bugs] #25118 [Core Tor/Tor]: We need circuit launch and cannibalization unit tests

[Tor Bug Tracker & Wiki]

#25118: We need circuit launch and cannibalization unit tests
------------------------------+-----------------------------------
     Reporter:  dgoulet       |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  High          |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-circuit, tor-test
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+-----------------------------------
 In particular, these functions `circuit_launch_by_extend_info()` and
 `circuit_find_to_cannibalize()` really needs unit tests!

 They do so much and they are so core that we need to assess what they are
 doing is ok. See #24469 for an example of what it should have done.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25118>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online