[tor-bugs] #24700 [Core Tor/Tor]: sched: With KIST, a channel can be added more than once in the pending list

[Tor Bug Tracker & Wiki]

#24700: sched: With KIST, a channel can be added more than once in the pending list
-------------------------------------------+-------------------------------
 Reporter:  dgoulet                        |          Owner:  dgoulet
     Type:  defect                         |         Status:  needs_review
 Priority:  High                           |      Milestone:  Tor:
                                           |  0.3.3.x-final
Component:  Core Tor/Tor                   |        Version:  Tor:
                                           |  0.3.2.1-alpha
 Severity:  Normal                         |     Resolution:
 Keywords:  tor-sched, kist, 032-backport  |  Actual Points:
Parent ID:  #23993                         |         Points:
 Reviewer:  nickm                          |        Sponsor:
-------------------------------------------+-------------------------------

Comment (by nickm):

 dgoulet:

 1) Can you tell me something about how this was tested? How do we know it
 will work?

 2) When we merge to 0.3.3, should we remove the
 scheduler_set_channel_state() call instead?

 2) Do you think we should redundantly keep track of the "is_inserted"
 property in the sched_heap_idx field? (See my branch `24700_heap_idx_033`
 for an idea of what I mean.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24700#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online