[tor-bugs] #20006 [Core Tor/Tor]: HSFETCH fails for hidden services which use client authentication

[Tor Bug Tracker & Wiki]

#20006: HSFETCH fails for hidden services which use client authentication
-------------------------------------------------+-------------------------
 Reporter:  segfault                             |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, tor-spec, tor-control        |  Actual Points:
  missing-feature authentication hs-auth         |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by rl1987):

 * status:  new => needs_review


Comment:

 Implementing this turned out pretty simple, if we expect Tor to have
 `HidServAuth` configuration entry for target HS already. This enables us
 to refrain from doing any changes to torspec, as user can simply add
 `HidServAuth` through control port before attempting `HSFETCH`.

 See: https://github.com/torproject/tor/pull/621

 However I'm not sure what's the testing approach here? Should it be done
 with stem? It seems we don't have any existing unit-tests for
 `handle_control_hsfetch()` that I could extend.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20006#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online